Skip to content

token_swapper to accept generic map and to return its swaps as (G::NodeId, G::NodeId) #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

token_swapper to accept generic map and to return its swaps as (G::NodeId, G::NodeId) #1463

wants to merge 3 commits into from

Conversation

@gluonhiggs
Copy link
Contributor

@gluonhiggs gluonhiggs commented Jun 9, 2025 •
edited
Loading

Resolve #1437 and #1438
The modification is straightforward with some docs changes.
My first commit is to resolve #1437. My 2nd commit is for #1438

@coveralls
Copy link

coveralls commented Jun 9, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 15589798928

Details

  • 49 of 52 (94.23%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 95.27%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rustworkx-core/src/token_swapper.rs 30 33 90.91%
Totals Coverage Status
Change from base Build 15448809297: -0.01%
Covered Lines: 18973
Relevant Lines: 19915
💛 - Coveralls

@gluonhiggs gluonhiggs changed the title token_swapper to return its swaps as (G::NodeId, G::NodeId) rather than NodeIndex token_swapper to accept generic map and to return its swaps as (G::NodeId, G::NodeId) Jun 10, 2025
@1ucian0 1ucian0 linked an issue Jun 10, 2025 that may be closed by this pull request
token_swapper to accept generic map-and-support for target description #1438
Open
1ucian0
1ucian0 reviewed Jun 11, 2025
View reviewed changes
Copy link
Member

@1ucian0 1ucian0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a maintainer here. My understanding of https://github.com/Qiskit/rustworkx/blob/main/CONTRIBUTING.md is that you should add tests for this new functionality

@gluonhiggs
Copy link
Contributor Author

gluonhiggs commented Jun 11, 2025

Not a maintainer here. My understanding of https://github.com/Qiskit/rustworkx/blob/main/CONTRIBUTING.md is that you should add tests for this new functionality

I ran the existing tests and thought these were enough. Let me check again.

@gluonhiggs
Copy link
Contributor Author

gluonhiggs commented Jun 11, 2025

I have added new tests and modified the token_swapper rust core, wrapper, stub. Thank you for reminding me @1ucian0

@IvanIsCoding IvanIsCoding mentioned this pull request Jun 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1ucian0 1ucian0 1ucian0 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@mtreinish mtreinish

Labels

None yet

Projects

None yet

Milestone

No milestone

4 participants

@gluonhiggs @coveralls @1ucian0 @mtreinish